Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise plugin API #5068

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Revise plugin API #5068

merged 2 commits into from
Jul 25, 2024

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

The API interface for pipedv1 plugin changed as follow

pkg/plugin/api/v1alpha1
├── client.go
├── deployment // API for deployment related actions
│   ├── api.pb.go
│   ├── api.pb.validate.go
│   ├── api.proto
│   └── api_grpc.pb.go
├── driftdetection  // API for drift detection related actions
└── livestate  // API for livestate related actions

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 22.80%. Comparing base (60c4a53) to head (8641907).

Files Patch % Lines
...kg/app/pipedv1/plugin/kubernetes/planner/server.go 0.00% 12 Missing ⚠️
pkg/plugin/api/v1alpha1/client.go 0.00% 3 Missing ⚠️
pkg/app/pipedv1/controller/pluginregistry.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/plugin/inputs.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5068      +/-   ##
==========================================
+ Coverage   22.73%   22.80%   +0.07%     
==========================================
  Files         410      410              
  Lines       43514    43382     -132     
==========================================
+ Hits         9892     9895       +3     
+ Misses      32844    32709     -135     
  Partials      778      778              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only v1 files are affected.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@khanhtc1202 khanhtc1202 merged commit 4845a1d into master Jul 25, 2024
24 of 25 checks passed
@khanhtc1202 khanhtc1202 deleted the revise-plugin-api branch July 25, 2024 07:21
This was referenced Jul 29, 2024
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants