Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin deployment api #5110

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Update plugin deployment api #5110

merged 1 commit into from
Aug 5, 2024

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 marked this pull request as ready for review August 3, 2024 07:25
@khanhtc1202
Copy link
Member Author

Note: merge this before PR #5074

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.82%. Comparing base (d805cf5) to head (621ab58).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5110      +/-   ##
==========================================
- Coverage   22.82%   22.82%   -0.01%     
==========================================
  Files         409      409              
  Lines       43338    43343       +5     
==========================================
  Hits         9891     9891              
- Misses      32668    32673       +5     
  Partials      779      779              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only v1alpha1 is included.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@khanhtc1202 khanhtc1202 merged commit f5dcaa4 into master Aug 5, 2024
18 checks passed
@khanhtc1202 khanhtc1202 deleted the update-plugin-api branch August 5, 2024 01:21
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants