Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Release version text #5192

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Fix Release version text #5192

merged 5 commits into from
Sep 6, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Sep 6, 2024

What this PR does / why we need it:

Since the site is launched by the following command,
the RELEASE file should start with tag: vX.Y.Z.

pipecd/Makefile

Line 153 in daf0a09

env RELEASE=$(shell head -n 1 RELEASE | cut -d ' ' -f 2) hugo server --source=docs

Now: Generated is shown. (other docs too)
image~

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 6, 2024

RELEASE

No GitHub releases will be created one this pull request got merged. Because the following tags were already created before.

  • v0.48.8

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.86%. Comparing base (e7c40a0) to head (9612286).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5192   +/-   ##
=======================================
  Coverage   22.86%   22.86%           
=======================================
  Files         420      420           
  Lines       45247    45247           
=======================================
  Hits        10344    10344           
  Misses      34108    34108           
  Partials      795      795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202
Copy link
Member

@t-kikuc could you test with make release command?

ffjlabo
ffjlabo previously approved these changes Sep 6, 2024
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t-kikuc
Copy link
Member Author

t-kikuc commented Sep 6, 2024

@khanhtc1202 I'm testing and fixing

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 6, 2024

RELEASE

No GitHub releases will be created one this pull request got merged. Because the following tags were already created before.

  • v0.48.8

@t-kikuc
Copy link
Member Author

t-kikuc commented Sep 6, 2024

@khanhtc1202 I fixed 9e4cab5

RELEASE Outdated
# Generated by `make release` command.
# DO NOT EDIT.
tag: v0.48.8
tag: v0.48.8 # Generated by `make release` command. DO NOT EDIT.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep this file as is, since other generated file usually have the comment about it on the top 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverts commit 9e4cab5.

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
This reverts commit daf0a09.

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@t-kikuc t-kikuc merged commit 3994f61 into master Sep 6, 2024
17 checks passed
@t-kikuc t-kikuc deleted the fix-version branch September 6, 2024 04:26
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants