-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Release version text #5192
Fix Release version text #5192
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5192 +/- ##
=======================================
Coverage 22.86% 22.86%
=======================================
Files 420 420
Lines 45247 45247
=======================================
Hits 10344 10344
Misses 34108 34108
Partials 795 795 ☔ View full report in Codecov by Sentry. |
@t-kikuc could you test with make release command? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@khanhtc1202 I'm testing and fixing |
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@khanhtc1202 I fixed 9e4cab5 |
RELEASE
Outdated
# Generated by `make release` command. | ||
# DO NOT EDIT. | ||
tag: v0.48.8 | ||
tag: v0.48.8 # Generated by `make release` command. DO NOT EDIT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep this file as is, since other generated file usually have the comment about it on the top 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khanhtc1202 fixed
9612286
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What this PR does / why we need it:
Since the site is launched by the following command,theRELEASE
file should start withtag: vX.Y.Z
.pipecd/Makefile
Line 153 in daf0a09
Now:
Generated
is shown. (other docs too)~
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: