Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy platform provider kubernetes under the plugin directory #5250

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Oct 3, 2024

What this PR does / why we need it:

This PR copies k8s' platform provider implementations under its plugin.
I want to start implementing the Kubernetes plugin by copying the existing platform provider implementations.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@Warashi Warashi changed the title [DO NOT MERGE / WIP] Copy platform provider kubernetes under the plugin directory Copy platform provider kubernetes under the plugin directory Oct 3, 2024
@Warashi Warashi marked this pull request as ready for review October 3, 2024 00:48
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 21.13668% with 1679 lines in your changes missing coverage. Please review.

Project coverage is 23.93%. Comparing base (38d647a) to head (1555490).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...kg/app/pipedv1/plugin/kubernetes/provider/state.go 0.00% 433 Missing ⚠️
pkg/app/pipedv1/plugin/kubernetes/provider/helm.go 19.93% 232 Missing and 5 partials ⚠️
.../app/pipedv1/plugin/kubernetes/provider/kubectl.go 0.00% 213 Missing ⚠️
.../app/pipedv1/plugin/kubernetes/provider/applier.go 0.00% 167 Missing ⚠️
...app/pipedv1/plugin/kubernetes/provider/manifest.go 27.87% 115 Missing and 4 partials ⚠️
...g/app/pipedv1/plugin/kubernetes/provider/loader.go 11.81% 112 Missing ⚠️
.../pipedv1/plugin/kubernetes/provider/resourcekey.go 27.85% 93 Missing and 8 partials ⚠️
pkg/app/pipedv1/plugin/kubernetes/provider/diff.go 49.74% 87 Missing and 12 partials ⚠️
...ernetes/provider/kubernetestest/kubernetes.mock.go 0.00% 61 Missing ⚠️
.../plugin/kubernetes/provider/chartrepo/chartrepo.go 0.00% 40 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5250      +/-   ##
==========================================
- Coverage   24.06%   23.93%   -0.13%     
==========================================
  Files         439      455      +16     
  Lines       46957    49086    +2129     
==========================================
+ Hits        11301    11751     +450     
- Misses      34753    36387    +1634     
- Partials      903      948      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi merged commit c866fa3 into master Oct 4, 2024
22 of 24 checks passed
@Warashi Warashi deleted the pipedv1-k8s-plugin-copy-platformproviders branch October 4, 2024 05:44
Warashi added a commit that referenced this pull request Oct 4, 2024
Warashi added a commit that referenced this pull request Oct 7, 2024
…5250)"

This reverts commit c866fa3.

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi added a commit that referenced this pull request Oct 7, 2024
…5250)" (#5253)

This reverts commit c866fa3.

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants