Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #5266 #5268 #5269 #5272 #5273

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 9, 2024

What this PR does / why we need it:
Cherry pick of #5266 #5268 #5269 #5272.

Warashi and others added 4 commits October 9, 2024 05:31
* Add pull-requests permission to the workflow

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>

* Set the base branch to the default branch of the repository

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>

* Use `github.ref_name` to determine the version of manifests

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>

* Checkout master branch to make PR to master branch

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
* Remove pipectl quickstart command

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Remove the quickstart from docs

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
* add liveStateInterval for Lambda

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* add docs of liveStateInterval

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* fix a test

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Rename to 'awsAPIPollingInterval'

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@t-kikuc t-kikuc enabled auto-merge (squash) October 9, 2024 05:34
@t-kikuc t-kikuc merged commit eb98030 into release-v0.49.x Oct 9, 2024
15 checks passed
@t-kikuc t-kikuc deleted the cherry-pick-#5266-#5268-#5269-#5272-to-release-v0.49.x branch October 9, 2024 05:37
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.97%. Comparing base (fa404a8) to head (2ec80b5).
Report is 1 commits behind head on release-v0.49.x.

Files with missing lines Patch % Lines
pkg/app/piped/livestatestore/lambda/lambda.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-v0.49.x    #5273      +/-   ##
===================================================
+ Coverage            22.80%   22.97%   +0.16%     
===================================================
  Files                  419      418       -1     
  Lines                45390    45045     -345     
===================================================
- Hits                 10351    10347       -4     
+ Misses               34244    33902     -342     
- Partials               795      796       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants