Delete platform-specific specs from configv1 #5300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Warashi
commented
Oct 31, 2024
| @@ -104,30 +105,10 @@ func (c *Config) init(kind Kind, apiVersion string) error { | |||
| c.APIVersion = apiVersion | |||
|
|
|||
| switch kind { | |||
| case KindApplication: | |||
| case KindApplication, KindKubernetesApp, KindTerraformApp, KindCloudRunApp, KindLambdaApp, KindECSApp: | |||
There was a problem hiding this comment.
To have backward compatibility, we treat them as the same as the KindApplication.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5300 +/- ##
==========================================
+ Coverage 25.14% 25.16% +0.01%
==========================================
Files 449 444 -5
Lines 47642 47504 -138
==========================================
- Hits 11980 11954 -26
+ Misses 34717 34606 -111
+ Partials 945 944 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
We move platform-specific config to plugins, so we don't want these at the configv1 package.
I copied them on #5237, but I realized it was not a good way to copy all of them, so I removed some parts on this PR.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: