Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove Compatibilities from ECS examples #5301

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Oct 31, 2024

What this PR does:

as title

Why we need it:

Compatibilities cannot be used because RegisterTaskDefinitionInput does not have it.
It's confusing for users.

cf.

  • https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/ecs@v1.46.2#RegisterTaskDefinitionInput
  • Although types.TaskDefinition has it, we cannot pass it when registering.
    func (c *client) RegisterTaskDefinition(ctx context.Context, taskDefinition types.TaskDefinition) (*types.TaskDefinition, error) {
    input := &ecs.RegisterTaskDefinitionInput{
    Family: taskDefinition.Family,
    ContainerDefinitions: taskDefinition.ContainerDefinitions,
    RequiresCompatibilities: taskDefinition.RequiresCompatibilities,
    ExecutionRoleArn: taskDefinition.ExecutionRoleArn,
    TaskRoleArn: taskDefinition.TaskRoleArn,
    NetworkMode: taskDefinition.NetworkMode,
    Volumes: taskDefinition.Volumes,
    RuntimePlatform: taskDefinition.RuntimePlatform,
    EphemeralStorage: taskDefinition.EphemeralStorage,
    // Requires defined at task level in case Fargate is used.
    Cpu: taskDefinition.Cpu,
    Memory: taskDefinition.Memory,
    // TODO: Support tags for registering task definition.
    }

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.16%. Comparing base (ad3c877) to head (2fdaa53).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5301      +/-   ##
==========================================
+ Coverage   25.14%   25.16%   +0.01%     
==========================================
  Files         449      449              
  Lines       47642    47642              
==========================================
+ Hits        11980    11988       +8     
+ Misses      34717    34708       -9     
- Partials      945      946       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I didn't know that

@t-kikuc t-kikuc merged commit 548a804 into master Oct 31, 2024
18 checks passed
@t-kikuc t-kikuc deleted the example-ecs-remove-compatibilities branch October 31, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants