Add tests for pipedv1 executor package #5303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
requested review from
nghialv,
kentakozuka,
ffjlabo,
t-kikuc and
Warashi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5303 +/- ##
==========================================
+ Coverage 25.11% 25.22% +0.10%
==========================================
Files 444 444
Lines 47469 47470 +1
==========================================
+ Hits 11924 11976 +52
+ Misses 34604 34553 -51
Partials 941 941 ☔ View full report in Codecov by Sentry. |
t-kikuc
reviewed
Oct 31, 2024
|
|
||
| for _, tc := range testcases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| tc.got = DetermineStageStatus(tc.sig, tc.ori, tc.got) |
There was a problem hiding this comment.
Suggested change
| tc.got = DetermineStageStatus(tc.sig, tc.ori, tc.got) | |
| got := DetermineStageStatus(tc.sig, tc.ori, tc.got) |
How about removing tc.got? Is it impossible?
There was a problem hiding this comment.
Sorry, that was my mistake 🙏
There was a problem hiding this comment.
thank you,
hahaha, I didn't notice DetermineStageStatus(sig StopSignalType, ori, got model.StageStatus) has got too, I was confused.
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
t-kikuc
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: