Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FindRollbackStage logic to use pipeline stage rollback value #5313

Closed
wants to merge 2 commits into from

Conversation

khanhtc1202
Copy link
Member

What this PR does:

We added rollback to pipelineStage model recently, so I updated the FindRollbackStage logic to depend on that field too

Why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 25.31%. Comparing base (7676161) to head (242b995).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/controller/scheduler.go 0.00% 13 Missing ⚠️
pkg/app/pipedv1/controller/controller.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5313      +/-   ##
==========================================
+ Coverage   25.27%   25.31%   +0.03%     
==========================================
  Files         444      444              
  Lines       47503    47476      -27     
==========================================
+ Hits        12006    12017      +11     
+ Misses      34555    34517      -38     
  Partials      942      942              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant