Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #5295 #5299 #5306 #5308 #5310 #5312 #5315 #5316

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 7, 2024

What this PR does / why we need it:
Cherry pick of #5295 #5299 #5306 #5308 #5310 #5312 #5315.

ffjlabo and others added 7 commits November 7, 2024 07:10
* Add contexts to the RegisterEventRequest

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Add contexts to model.Event

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Store event context in Control Plane

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Add trailers when commiting on event watcher

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Fix for failed build

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

---------

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
…sage page (#5299)

* Add docs for pipectl event register --contexts on the event watcher usage page

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Fix docs

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Fix command

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

---------

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
* fix: skip push if no diff exist

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* modify message

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* refactor: use noChange variable

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
#5312)

* Execute git clean partially when drift detection for every app is done

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Rename to CleanPath

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Add test for the outside dir pattern

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

---------

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
@ffjlabo
Copy link
Member

ffjlabo commented Nov 7, 2024

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 39.51613% with 75 lines in your changes missing coverage. Please review.

Project coverage is 23.01%. Comparing base (eb98030) to head (eae0085).
Report is 1 commits behind head on release-v0.49.x.

Files with missing lines Patch % Lines
pkg/app/piped/eventwatcher/eventwatcher.go 0.00% 26 Missing ⚠️
pkg/app/piped/driftdetector/kubernetes/detector.go 0.00% 12 Missing ⚠️
pkg/git/gittest/git.mock.go 0.00% 12 Missing ⚠️
pkg/app/pipedv1/eventwatcher/eventwatcher.go 0.00% 8 Missing ⚠️
pkg/app/piped/driftdetector/lambda/detector.go 69.56% 7 Missing ⚠️
pkg/app/pipectl/cmd/event/register.go 0.00% 5 Missing ⚠️
pkg/app/piped/driftdetector/ecs/detector.go 86.95% 3 Missing ⚠️
pkg/app/server/grpcapi/api.go 0.00% 1 Missing ⚠️
pkg/git/repo.go 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-v0.49.x    #5316      +/-   ##
===================================================
+ Coverage            22.97%   23.01%   +0.03%     
===================================================
  Files                  418      418              
  Lines                45045    45115      +70     
===================================================
+ Hits                 10347    10381      +34     
- Misses               33902    33939      +37     
+ Partials               796      795       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ffjlabo ffjlabo merged commit e5fe1cf into release-v0.49.x Nov 7, 2024
17 checks passed
@ffjlabo ffjlabo deleted the cherry-pick-#5295-#5299-#5306-#5308-#5310-#5312-#5315-to-release-v0.49.x branch November 7, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants