Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tribe name in repository.json #31

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

bashmach
Copy link
Member

No description provided.

@bashmach bashmach requested a review from a team as a code owner May 31, 2024 11:48
@bashmach bashmach added npm-ready-for-publish used for deployment npm-version-patch used for deployment and removed npm-ready-for-publish used for deployment labels May 31, 2024
@Reivilo85k Reivilo85k self-assigned this May 31, 2024
Copy link
Contributor

@Reivilo85k Reivilo85k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bashmach bashmach added npm-ready-for-publish used for deployment and removed npm-ready-for-publish used for deployment labels May 31, 2024
@bashmach bashmach added npm-ready-for-publish used for deployment and removed npm-ready-for-publish used for deployment labels May 31, 2024
@pipedrive-bot-dora
Copy link

Neodora Analysis ⚠

⚠ Missing cache in Github Workflow

Message: Github workflow should be using caching when step uses actions/setup-node

Workflow file Job name Step index Actual cache value Expected cache value
on-commit.yml lint 2 Not found npm

🔍 How to fix it

⚠ Use of actively maintained version of Node.js

Message: A service using Node.js should use an actively maintained version before it reaches EOL.

Current Node.js version Message
16 The current version of Node.js has already reached its EOL (2023-09-11)

🔍 How to fix it

⚠ Incorrect runner in Github Workflow

Message: Github workflow must run on a self-hosted runner

Workflow file Job name Actual runs-on value Expected runs-on value
on-commit.yml lint ubuntu-latest Any of [eks-runner, eks-runner-php, eks-runner-nano, eks-runner-debug, eks-runner-compute, eks-runner-cd, eks-runner-ci, eks-runner-neodora, eks-runner-neodora-bulk, eks-runner-secops]

🔍 How to fix it

Commit c256071 Job 408010

pipedrive-bot pushed a commit that referenced this pull request May 31, 2024
@pipedrive-bot pipedrive-bot merged commit c256071 into master May 31, 2024
3 checks passed
@pipedrive-bot pipedrive-bot deleted the test-cicdv2-release branch May 31, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm-ready-for-publish used for deployment npm-version-patch used for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants