Profile Custom Username Links + Backend Validation #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://pipelines-pr-168.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cog1nt0l6cac73citeq0. |
✅ Deploy Preview for pipelineslol ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some feedback received was the addition of custom profile links, so when sharing it can share something like "https://pipelines.lol/user/name", which is what this PR brings! Also moved some frontend validation to the backend, where it belongs.
Profile Custom Links
server/controllers/profileController.js- Added an endpoint to get profiles by username.server/routes/profiles.js- Routes for the above endpoint ^.client/src/pages/Profile.js- Added logic to check if the id in the URL is a MongoDB ID, if not, check if it is a valid username.Backend Validation - Moving over frontend -> backend
client/src/pages/Profile.js- Burned all the frontend validation and Linkedin manipulation.client/src/components/ProfilePicture.js- Not sure why the profile picture was fetching from params in the first place... made it fetch from the inputted profile data.LONG LIVE PIPELINES! 🚀