Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy2 draft #3563

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Numpy2 draft #3563

wants to merge 4 commits into from

Conversation

YoungMind1
Copy link
Contributor

@YoungMind1 YoungMind1 commented Nov 8, 2024

I Wanted to share my the findings here.

  • I think Cython upgrade is necessary according to this.
  • Swapping except * and nogil in Cython files are due to compiler warnings, shouldn't affect anything.
  • The addition of noexcept in many functions is due to the acquiring of gil to check exceptions. but in past versions of Cython functions without explicit declaration of except would "swallow" exceptions. so this change should not affect anything. related make gensim CI great again #3488 , Cython link
  • 9 tests are failing, the one I really dug into was gensim/test/test_word2vec.py::TestWord2VecModel::test_similarities which should be due to changes in numpy datatype promotions link

I don't have the expertise or the time to fix these failing tests, just wanted to give a head start to anyone willing.
cc: @hechth
related #3562

@hechth
Copy link

hechth commented Nov 8, 2024

@YoungMind1 thanks a lot, I'll merge your PR into mine locally and continue with the tests since you did complementary things. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants