Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python version support #178

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Update Python version support #178

merged 9 commits into from
Jun 13, 2024

Conversation

tianyizheng02
Copy link
Contributor

Add older versions of Python to GitHub Actions workflows to determine actual supported versions (see this comment)

@tianyizheng02
Copy link
Contributor Author

As shown above, PittAPI is currently compatible with Python >= 3.9

@tianyizheng02 tianyizheng02 marked this pull request as ready for review June 12, 2024 06:19
@tianyizheng02
Copy link
Contributor Author

Tests for Python 3.9 are now failing because my other PR #176 introduced the pipe operator for type hints (A | B rather than Union[A, B]) and this breaks support for 3.9. I'm going to add from __future__ import annotations to see if this helps us maintain compatibility with 3.9.

Add the import `from __future__ import annotations` to Python files that
use the pipe operator (`A | B` instead of `Union[A, B]`) in order to
maintain compatibility with Python 3.9
@tianyizheng02 tianyizheng02 merged commit 51b925a into dev Jun 13, 2024
4 checks passed
@tianyizheng02 tianyizheng02 deleted the update-py-support branch June 13, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants