Clean up dependences #182
Merged
Clean up dependences #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove nose and related dependencies from Pipfile and Pipfile.lock because we no longer use nose for testing
We've already phased out bs4 and parse in favor of other packages such as requests
The lxml package was only used as a downstream dependency for the people module of the API, but now the required functionality has been offloaded to a new package, lxml_html_clean. As a result, people.py and people_test.py now fail with the following error message: E ImportError: lxml.html.clean module is now a separate project lxml_html_clean. E Install lxml[html_clean] or lxml_html_clean directly.
Move dev dependencies (black, flake8, etc.) under [dev-packages] in Pipfile
Remove virtualenv from Pipfile since we now use pipenv for venvs and dependency management
Set versions for coverage and pytest-cov to "*" since there's no need to stick with the existing specific versions and it should be safe to do so
Move sphinx to [dev-packages] in Pipfile because it's only used for building documentation and not required for the running of the API itself
|
Commit ea17ee4 updates
and thus this PR supersedes #184. |
|
Final issue is just what to do about |
Remove pytest-xdist from Pipfile since it's never used in any pytest workflows
nij-patel
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
Cleaned up dependencies (Pipfile and requirements.txt) by removing unused dependencies, updating dependencies to latest versions, and marking dependencies as dev dependencies where applicable. "Dev dependency" here refers to any dependency that we only use for development purposes (e.g., flake8 for linting, pytest for testing, and sphinx for documentation) and isn't required for the functionality of the API itself.