-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V4.0.0 #644
Draft
yue4u
wants to merge
404
commits into
main
Choose a base branch
from
v4.0.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an/add-tag-item-v4
…an/update-icon-button-v4
feat(react): update radio v4
feat(react): update loading spinner v4
feat: update FieldLabel v4
…sai/feat-update-textfield-api-v4
…sai/feat-update-modal-v4
feat: update Modal v4
feat(react): update tag item v4
…sai/feat-update-textfield-api-v4
…an/update-icon-button-v4
feat(react): update icon button v4
feat: update TextField and TextArea API
…sai/feat-add-rounded-checkbox
…tize the svg content before passing to charcoal
token json を結合して color や数値をとれるトークンオブジェクトを作成する
fix!(@charcoal-ui/icons): remove dompurify from v4.
…ke-2 chore(@charcoal-ui/tailwind-config): add test for defaultConfig
fix(@charcoal-ui/theme)!: unify css variables json
…an/replace-token1
classNameをリレーする。 TextFieldはpropsとしてclassNameを受け取っているが、それを渡している部分がなく、styled()などで上書きすることができない状態になっていた。
fix: pass down className prop
fix: update CI config
fix: update design token usage
Update Design Tokens, Add CSS Variables Tests, and Introduce Custom CSS Variables for `@charcoal-ui/react`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
動作確認環境
チェックリスト
不要なチェック項目は消して構いません