Skip to content

Commit

Permalink
fix: expressions, update isBinary behavior according to the spec
Browse files Browse the repository at this point in the history
I will update test cases in the next commit

See: https://github.com/vrm-c/vrm-specification/blob/master/specification/VRMC_vrm-1.0/expressions.md#expression-specification

The suggestion: #1489

Co-authored-by: ke456-png <108649297+ke456-png@users.noreply.github.com>
  • Loading branch information
0b5vr and ke456-png authored Oct 21, 2024
1 parent 3913e81 commit 5afd3fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/three-vrm-core/src/expressions/VRMExpression.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export class VRMExpression extends THREE.Object3D {
*/
public get outputWeight(): number {
if (this.isBinary) {
return this.weight >= 0.5 ? 1.0 : 0.0;
return this.weight > 0.5 ? 1.0 : 0.0;
}

return this.weight;
Expand Down

0 comments on commit 5afd3fc

Please sign in to comment.