Merge pull request #1525 from pixiv/improve-animation-hips-warning

fix: VRMAnimationLoaderPlugin, Improve hips position warning
pixiv · Nov 8, 2024 · 8969c04 · 8969c04
2 parents acda26a + e27e182
commit 8969c04
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/three-vrm-animation/src/VRMAnimationLoaderPlugin.ts b/packages/three-vrm-animation/src/VRMAnimationLoaderPlugin.ts
@@ -77,11 +77,11 @@ export class VRMAnimationLoaderPlugin implements GLTFLoaderPlugin {
     const restHipsPosition = new THREE.Vector3();
     hips?.getWorldPosition(restHipsPosition);
 
-    // If the rest hips position is approximately zero,
+    // If the y component of the rest hips position is approximately zero or below,
     // it is considered that the animation violates the VRM T-pose
-    if (restHipsPosition.lengthSq() < 1e-6) {
+    if (restHipsPosition.y < 1e-3) {
       console.warn(
-        'VRMAnimationLoaderPlugin: The loaded VRM Animation violates the VRM T-pose (The rest hips position is approximately zero.)',
+        'VRMAnimationLoaderPlugin: The loaded VRM Animation might violate the VRM T-pose (The y component of the rest hips position is approximately zero or below.)',
       );
     }