Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use lint-staged also for examples directories #1336

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Nov 28, 2023

Sequel of #1332

This PR make it use lint-staged also for examples directories.

for examples directory, ts and tsx are not needed to be checked, removed them

for examples directory, ts and tsx are not needed to be checked, removed them
@0b5vr 0b5vr added this to the next milestone Nov 28, 2023
@0b5vr 0b5vr requested a review from ke456-png November 28, 2023 07:56
@0b5vr 0b5vr self-assigned this Nov 28, 2023
@0b5vr 0b5vr requested a review from yue4u November 28, 2023 08:05
Copy link
Contributor

@yue4u yue4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local environment and it worked well.

},
"lint-staged": {
"./src/**/*.{ts,tsx}": [
"eslint --fix",
"prettier --write"
],
"./examples/**/*.{js,html}": [
"eslint --fix --rule \"padded-blocks: error\""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memo: just like ts,tsx files --fix option will be applied and potentially change the staged code.

Copy link
Contributor

@ke456-png ke456-png left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! 👍

@0b5vr 0b5vr merged commit e84c516 into dev Dec 4, 2023
6 checks passed
@0b5vr 0b5vr deleted the lint-staged-examples branch December 4, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants