Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousal img overflow problem solved #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 53 additions & 57 deletions src/components/Carousel/Carousel.js
Original file line number Diff line number Diff line change
@@ -1,62 +1,58 @@
import axios from "axios";
import React, { useEffect, useState } from "react";
import AliceCarousel from "react-alice-carousel";
import "react-alice-carousel/lib/alice-carousel.css";
import { img_300, noPicture } from "../../config/config";
import "./Carousel.css";
import axios from 'axios';
import React, { useEffect, useState } from 'react';
import AliceCarousel from 'react-alice-carousel';
import 'react-alice-carousel/lib/alice-carousel.css';
import { img_300, noPicture } from '../../config/Config';
import './Carousel.css';

const handleDragStart = (e) => e.preventDefault();

const Gallery = ({ id, media_type }) => {
const [credits, setCredits] = useState([]);

const items = credits.map((c) => (
<div className="carouselItem">
<img
src={c.profile_path ? `${img_300}/${c.profile_path}` : noPicture}
alt={c?.name}
onDragStart={handleDragStart}
className="carouselItem__img"
/>
<b className="carouselItem__txt">{c?.name}</b>
</div>
));

const responsive = {
0: {
items: 3,
},
512: {
items: 5,
},
1024: {
items: 7,
},
};

const fetchCredits = async () => {
const { data } = await axios.get(
`https://api.themoviedb.org/3/${media_type}/${id}/credits?api_key=${process.env.REACT_APP_API_KEY}&language=en-US`
);
setCredits(data.cast);
};

useEffect(() => {
fetchCredits();
// eslint-disable-next-line
}, []);

return (
<AliceCarousel
mouseTracking
infinite
disableDotsControls
disableButtonsControls
responsive={responsive}
items={items}
autoPlay
/>
);
const Carousel = ({ id, media_type }) => {
const [credits, setCredits] = useState([]);

const items = credits?.map((c) => (
<div className="carouselItem">
<img
src={c.profile_path ? `${img_300}/${c.profile_path}` : noPicture}
alt={c.name}
onDragStart={handleDragStart}
className="carouselItem__img"
/>
<b className="carouselItem__txt">{c?.name}</b>
</div>
));

const responsive = {
0: { items: 3 },
512: { items: 4 },
666: { items: 5 },
1241: { items: 6 },
1361: { items: 7 }
};

const fetchCredits = async () => {
const { data } = await axios.get(
`https://api.themoviedb.org/3/${media_type}/${id}/credits?api_key=${process.env.REACT_APP_API_KEY}&language=en-US`
);
setCredits(data.cast);
};

useEffect(() => {
fetchCredits();
// eslint-disable-next-line
}, []);
// console.log(credits);
return (
<AliceCarousel
autoPlay={credits.length > 2}
responsive={responsive}
disableDotsControls
disableButtonsControls
infinite
mouseTracking
items={items}
/>
);
};

export default Gallery;
export default Carousel;
piyush-eon marked this conversation as resolved.
Show resolved Hide resolved