Feature/jaino/#140 #146
Merged
Feature/jaino/#140 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongjaino
added
๐์งํธ๐
3 tasks
tgyuuAn
approved these changes
Mar 2, 2024
Comment on lines
+25
to
+27
|
|
||
| if (duration.toMinutes() == 0L) { | ||
| return "๋ฐฉ๊ธ" |
There was a problem hiding this comment.
๋ฐฉ๊ธ ์ฌ๋ฐ๋๋ฐ์ ์งํธ์ ใ ใ ใ ใ
tgyuuAn
added
๐๋จธ์ง ํด์ฃผ์ธ์๐
tgyuuAn
reviewed
Mar 3, 2024
Comment on lines
+26
to
+41
| if (duration.toMinutes() == 0L) { | ||
| return "๋ฐฉ๊ธ" | ||
| } else if (duration.toMinutes() < 60) { | ||
| val leftMinutes = duration.toMinutes().toString() | ||
| return leftMinutes + "๋ถ ์ ์์ฑ" | ||
| } | ||
|
|
||
| if (duration.toHours() < 24) { | ||
| val leftHours = duration.toHours().toString() | ||
| return leftHours + "์๊ฐ ์ ์์ฑ" | ||
| } | ||
|
|
||
| if (duration.toDays() < 31) { | ||
| val leftDays = duration.toDays().toString() | ||
| return leftDays + "์ผ ์ ์์ฑ" | ||
| } |
There was a problem hiding this comment.
์ฌ๊ธฐ ๋งค์ง๋๋ฒ๋ค์ ์์ํ ์ํฌ ๋ง ํ ๊น์ ...?
๋ง์ฝ ํ๋ค๋ฉด ๋ค๋ฅธ ๊ณณ๋ค๋ ๋ค ํ๊ธด ํด์ผ ํ ํ ๋ฐ ..
There was a problem hiding this comment.
ํ๋ค๋ฉด companionObject ๋ด์์ ํด์ผํ๋๋ฐ
๋ฌธ๋งฅ์ ์ดํด๊ฐ ๋ผ์
์ ๋ ๊ทธ๋ฅ ๊ทธ๋๋ก ๋๋ฌ๋ ๋ฌด๋ฐฉํ ๊ฒ ๊ฐ์์ ใ
ใ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. ๐ ๊ด๋ จ๋ ์ด์ ๋ฐ ์๊ฐ
#140 ์ค๋ฌธ ๊ด๋ฆฌ ํ์ด์ง UI ๊ฐ์ ๋ฐ Dummy Data ์๊ฑฐ
2. ๐ฅ ๋ณ๊ฒฝ๋ ์
3. โ ๊ผญ ํ์ธํด์คฌ์ผ๋ฉด ํ๋ ๋ถ๋ถ
ํผ๊ทธ๋ง์ ์ค๋ฌธ ์ ๋ ฌ ๋ฐ ๊ฒ์ ๊ธฐ๋ฅ์ด ํฌํจ๋ ๋์์ธ์ผ๋ก ๋ง๋ค์ด๋จ๋๋ฐ
ํผ๊ทธ๋ง ๋ด ์ฝ๋ฉํธ ํ์ธ ๋ถํ๋๋ฆฝ๋๋ค !
(ํ์ฌ ์ด์์ ๋ณ๊ฐ์ ๊ธฐ๋ฅ์ด๋ผ์ ๋ฐ๋ก ์ ๋ ฌ ๋ฒํผ์ ๊ตฌํํ์ง ์์์ต๋๋ค.)
4. ๐ธ ์คํฌ๋ฆฐ์ท(์ ํ)
์ด์ ์ค๋ฌธ ํ์ธ ๋์์ธ
๊ตฌํ ๋์์ธ
ํผ๊ทธ๋ง ๋์์ธ
5. ๐ก์๊ฒ๋ ํน์ ๊ถ๊ธํ ์ฌํญ๋ค
Compose Text ์์ฑ์ค OverFlow๋ฅผ ํ์ฉํ๋ฉด ๊ธ์๊ฐ ๋๊ฒผ์ ๋ ...์ผ๋ก ์ฒ๋ฆฌํ ์ ์๋ค.
Compose Text Overflow