Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/tgyuu/#150 #151

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Refactor/tgyuu/#150 #151

merged 5 commits into from
Mar 5, 2024

Conversation

tgyuuAn
Copy link
Member

@tgyuuAn tgyuuAn commented Mar 5, 2024

1. ๐Ÿ“„ ๊ด€๋ จ๋œ ์ด์Šˆ ๋ฐ ์†Œ๊ฐœ

2. ๐Ÿ”ฅ ๋ณ€๊ฒฝ๋œ ์ 

  • Noticeํ™”๋ฉด ๋ฐ”ํ…€์‹œํŠธ ๋‘ฅ๊ธ€๊ฒŒ ๋ณด์ด๋„๋ก ๋ณ€๊ฒฝ
  • ์„ค๋ฌธ ํ™•์ธ ํŽ˜์ด์ง€ "~~์ผ ์ „ ์ž‘์„ฑ"์—์„œ "~~์ผ ์ „"์œผ๋กœ ๋ณ€๊ฒฝ
  • ์ผ์ • ๋“ฑ๋ก ํŽ˜์ด์ง€๋Š” ํ•˜๋‹จ ๋งˆ์ง„์ด ์ ์šฉ ์•ˆ๋˜์–ด์žˆ์ง€๋งŒ ์ผ์ • ์ˆ˜์ • ํŽ˜์ด์ง€๋Š” ํ•˜๋‹จ ๋งˆ์ง„์ด ์ ์šฉ๋˜์–ด์žˆ๋˜ ์‚ฌ์†Œํ•œ ์ด์Šˆ ํ•ด๊ฒฐ
  • ์„ค๋ฌธ ํ™•์ธ ํŽ˜์ด์ง€ LazyColumn VerticalArrangement ๋‹ค๋ฅธ UI๋“ค๊ณผ 16.dp๋กœ ํ†ต์ผ (๊ธฐ์กด 20.dp)

3. โœ… ๊ผญ ํ™•์ธํ•ด์คฌ์œผ๋ฉด ํ•˜๋Š” ๋ถ€๋ถ„

4. ๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท(์„ ํƒ)

๊ธฐ์กด

image

๋ณ€๊ฒฝ

image

5. ๐Ÿ’ก์•Œ๊ฒŒ๋œ ํ˜น์€ ๊ถ๊ธˆํ•œ ์‚ฌํ•ญ๋“ค

@tgyuuAn tgyuuAn added ๐ŸŽจ์œ ์•„์ด๐ŸŽจ ํ”ผ๊ทธ๋งˆ, ์—‘์„ธ๋ฉœ, ์ปดํฌ์ฆˆ ์œ ์•„์ด/์œ ์—‘์Šค ์ž‘์—… ๐Ÿงนํ—ˆ๋“œ๋ ›์ผ๐Ÿงน ์ข…์†์„ฑ ์ถ”๊ฐ€, ๊ธฐ๋Šฅ๊ณผ ๋ฌด๊ด€ํ•œ ์ฝ”๋“œ ์ž‘์„ฑ ๐Ÿงฉํƒœ๊ทœ๐Ÿงฉ ENFP ์•ˆํƒœ๊ทœ 24์„ธ labels Mar 5, 2024
@tgyuuAn tgyuuAn requested a review from jeongjaino March 5, 2024 04:50
@tgyuuAn tgyuuAn self-assigned this Mar 5, 2024
jeongjaino
jeongjaino approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L
G
T
M
T
G
L
๐Ÿ‘

@jeongjaino jeongjaino added the ๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. label Mar 5, 2024
@tgyuuAn tgyuuAn merged commit 90a052b into develop Mar 5, 2024
@tgyuuAn tgyuuAn deleted the refactor/tgyuu/#150 branch March 8, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongjaino jeongjaino jeongjaino approved these changes

Assignees

@tgyuuAn tgyuuAn

Labels
๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. ๐ŸŽจ์œ ์•„์ด๐ŸŽจ ํ”ผ๊ทธ๋งˆ, ์—‘์„ธ๋ฉœ, ์ปดํฌ์ฆˆ ์œ ์•„์ด/์œ ์—‘์Šค ์ž‘์—… ๐Ÿงฉํƒœ๊ทœ๐Ÿงฉ ENFP ์•ˆํƒœ๊ทœ 24์„ธ ๐Ÿงนํ—ˆ๋“œ๋ ›์ผ๐Ÿงน ์ข…์†์„ฑ ์ถ”๊ฐ€, ๊ธฐ๋Šฅ๊ณผ ๋ฌด๊ด€ํ•œ ์ฝ”๋“œ ์ž‘์„ฑ
Projects
None yet
Milestone
No milestone
2 participants
@tgyuuAn @jeongjaino