odpi#179 add option to set password for jupyter

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 · Sep 6, 2022 · 5844e8f · 5844e8f
1 parent 4cfdbd6
commit 5844e8f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/charts/odpi-egeria-lab/Chart.yaml b/charts/odpi-egeria-lab/Chart.yaml
@@ -4,7 +4,7 @@
 name: odpi-egeria-lab
 description: Egeria lab environment
 apiVersion: v2
-version: 3.11.0
+version: 3.11.1
 appVersion: "3.11"
 icon: https://raw.githubusercontent.com/odpi/egeria/99016e77167fa30dcfade809b061358a92a59973/assets/img/egeria.png
 keywords:

diff --git a/charts/odpi-egeria-lab/templates/jupyter.yaml b/charts/odpi-egeria-lab/templates/jupyter.yaml
@@ -87,6 +87,18 @@ spec:
               value: "YES"
             - name: DOCKER_STACKS_JUPYTER_CMD
               value: "lab --notebook-dir=/home/jovyan/work"
+            # If value not passed, a password will be generated, otherwise get from configmap (and must exist)
+            {{ if .Values.jupyter.tokenSecret }}
+            - name: JUPYTER_TOKEN
+              valueFrom:
+                secretKeyRef:
+                  name: {{ .Values.jupyter.tokenSecret }}
+                  key: password
+                  optional: false
+            {{ else if .Values.jupyter.tokenPlain }}
+            - name: JUPYTER_TOKEN
+              value: {{ .Values.jupyter.tokenPlain }}
+            {{ end }}
             # Contains the truststore from Egeria self-signed certs, in .pem format
             #- name: REQUESTS_CA_BUNDLE
             #  value: "/home/jovyan/ssl/truststore.pem"

diff --git a/charts/odpi-egeria-lab/values.yaml b/charts/odpi-egeria-lab/values.yaml
@@ -50,6 +50,11 @@ jupyter:
   scriptSleepAfter: "0"
   # Size for jupyter work
   storageSize: "1Gi"
+  # If assigned, will use the 'password' entry as the name of the secret to seed the Jupyter password
+  # to create: kubectl create secret generic jupyter-lab-secret --from-literal=password='s3cr3t!'
+  # tokenSecret:
+  # If passwordSecret not set, but passwordPlain is, we use this as cleartext **INSECURE**
+  # tokenPlain:
 
 debug:
   egeriaJVM: false