Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest vitess.io/vitess 2024-05-25 #22

Merged
merged 4 commits into from
May 25, 2024

Conversation

shlomi-noach
Copy link
Collaborator

Getting latest updates up to vitessio/vitess#16000

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Collaborator Author

shlomi-noach commented May 25, 2024

@dbussink there's a bump again in the number of imported packages, leading to significant increase in binary size. Is this something worth spending time investigating & cleaning up? The influx seems to be caused by vitess.io/vitess/go/vt/vtgate/vindexes / vitess.io/vitess/go/trace. e.g.:

$ go mod why github.com/philhofer/fwd
# github.com/philhofer/fwd
github.com/planetscale/schemadiff/pkg/base
vitess.io/vitess/go/vt/schemadiff
vitess.io/vitess/go/vt/vtgate/vindexes
vitess.io/vitess/go/vt/topotools
vitess.io/vitess/go/vt/topo
vitess.io/vitess/go/trace
gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer
github.com/tinylib/msgp/msgp
github.com/philhofer/fwd
$ go mod why github.com/DataDog/go-tuf v1.1.0-0.5.2
# github.com/DataDog/go-tuf
github.com/planetscale/schemadiff/pkg/base
vitess.io/vitess/go/vt/schemadiff
vitess.io/vitess/go/vt/vtgate/vindexes
vitess.io/vitess/go/vt/topotools
vitess.io/vitess/go/vt/topo
vitess.io/vitess/go/trace
gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer
github.com/DataDog/datadog-agent/pkg/remoteconfig/state
github.com/DataDog/go-tuf/client
github.com/DataDog/go-tuf/client.test
github.com/DataDog/go-tuf

@dbussink
Copy link
Contributor

vitessio/vitess#16008 should fix this I think.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Collaborator Author

Updated to include vitessio/vitess#16008 and reduce package dependencies.

@shlomi-noach shlomi-noach merged commit 0f2b38c into main May 25, 2024
1 check passed
@shlomi-noach shlomi-noach deleted the update-vitess-20240525 branch May 25, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants