Upgrade to go1.22.2 and upgrade Vitess Dependency to Latest
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
2 times, most recently
from
f2f5699
to
8898fbe
Compare
Signed-off-by: GitHub <noreply@github.com>
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
8898fbe
to
e5f9f5a
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
changed the title
go1.22.2 and upgrade Vitess Dependency to Latest
frouioui
approved these changes
Apr 29, 2024
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
|
Commit 501d5c8 reflects the changes made by vitessio/vitess#15791. It also decreases the timeout when checking the cluster setup, it used to be 300 seconds which does not make sense since we already have a 1200 seconds timeout for every item we are checking. I bumped the vtctldclient deps from v16 to v19 too. I will open a PR shortly to update the release documentation. |
frouioui
reviewed
Apr 29, 2024
| @@ -19,7 +19,7 @@ function checkSemiSyncSetup() { | |||
| function checkSemiSyncWithRetry() { | |||
| vttablet=$1 | |||
| for i in {1..600} ; do | |||
| kubectl exec "$vttablet" -c mysqld -- mysql -S "/vt/socket/mysql.sock" -u root -e "show variables like 'rpl_semi_sync_slave_enabled'" | grep "ON" | |||
| kubectl exec "$vttablet" -c mysqld -- mysql -S "/vt/socket/mysql.sock" -u root -e "show variables like 'rpl_semi_sync_%_enabled'" | grep "ON" | |||
There was a problem hiding this comment.
Check for both rpl_semi_sync_replica_enabled and rpl_semi_sync_slave_enabled
deepthi
approved these changes
Apr 29, 2024
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weekly Vitess dependency upgrade running on a cron schedule