Tablet throttler multi-metrics incremental PR: introducing metric names and scopes #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced by vitessio#16041
Description
Incremental PR in the Tablet Throttler multi-metric series of PRs as per vitessio#16012 and merging into vitessio#16012.
This PR merely introduces (and does not use yet) two noteworthy types:
MetricName
- a formalized name of a metric (lag
,threads_running
, etc.). There is a limited known set of names, though these are easily expandable programmatically.Scope
- the range of tablets for which a metric is collected. This is either he local tablet (self
) or the entire shard (shard
). When we speak of "the entire shard" we only regard the list of tables that participate in throttler activity. By default those areprimary
andreplica
.Related Issue(s)
vitessio#15624
Checklist
Deployment Notes