Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tablet throttler multi-metrics incremental PR: introducing metric names and scopes #93

Conversation

shlomi-noach
Copy link

@shlomi-noach shlomi-noach commented May 26, 2024

Replaced by vitessio#16041

Description

Incremental PR in the Tablet Throttler multi-metric series of PRs as per vitessio#16012 and merging into vitessio#16012.

This PR merely introduces (and does not use yet) two noteworthy types:

  • MetricName - a formalized name of a metric (lag, threads_running, etc.). There is a limited known set of names, though these are easily expandable programmatically.
  • Scope - the range of tablets for which a metric is collected. This is either he local tablet (self) or the entire shard (shard). When we speak of "the entire shard" we only regard the list of tables that participate in throttler activity. By default those are primary and replica.

Related Issue(s)

vitessio#15624

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

…es and scopes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Author

Replaced by vitessio#16041

@shlomi-noach shlomi-noach deleted the throttler-multi-metrics-incremental-metric-names branch July 2, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant