Added Caller interface to callback object methods. #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facorazza
reviewed
Jul 29, 2023
| @@ -29,6 +29,17 @@ | |||
|
|
|||
| #endif | |||
|
|
|||
| class EspMQTTClient; // forward declaration | |||
There was a problem hiding this comment.
Is this needed considering that the class definition is 4 rows below?
There was a problem hiding this comment.
Thanks, probably I just left it there from before. Works fine without it.
|
This could be a great addition but I have tested the code and it doesn't seem to be functional nor complete |
|
I'll update the example to a better one, for now there is a working example using this callback in my other repository https://github.com/dino-rider/IotDevice_test. Also I was working in PlatformIO, but I'm making an arduino example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble using the module in object oriented code. adding this interface and inheriting from it make it much easier to utilize.