Adopt binderhub
#83
Adopt binderhub
#83
Conversation
trungleduc
force-pushed
the
binderhub
branch
2 times, most recently
from
dab4e88 to
ec22d1f
Compare
trungleduc
force-pushed
the
binderhub
branch
2 times, most recently
from
331bc3b to
4e02472
Compare
|
Nice, thanks @trungleduc for working on this! Also cc @yuvipanda if you would like to help review and / or provide feedback. This should help with 2i2c-org/binderhub-service#78. |
|
|
||
| On GitHub and GitLab, a user might have to first create an access token with `read` access to use as the password: | ||
|
|
||
|  | ||
|
|
||
| > [!NOTE] | ||
| > The `binderhub` build backend does not support configuring private repositories credentials from the interface. |
There was a problem hiding this comment.
Should we open a new issue (or comment in #72) to keep track of the current issues with BinderHub and the default git provider?
|
This is super exciting to me. How can I help? Would it be via code review? Or something else? |
|
Hi @yuvipanda, a quick look at the implementation would be super helpful for us. |
| c.JupyterHub.hub_ip = public_ips()[0] | ||
| c.JupyterHub.cleanup_servers = False | ||
| c.JupyterHub.spawner_class = Repo2DockerSpawner | ||
| if hookimpl: |
There was a problem hiding this comment.
Maybe we should document why we have to conditionally define the TLJH hooks?
Probably to allow for the package to be used with the BinderHub chart on Kubernetes? If so, maybe the tljh_repo2docker should continue to focus on the TLJH integration (be a TLJH plugin) as before, and have a separate package for use with BinderHub?
There was a problem hiding this comment.
This could also likely be done separately, as the diff for this PR is already quite large.
Also the UI for building environments could eventually be its own jupyterhub-environment-builder package, and have tljh_repo2docker depend on it.
There was a problem hiding this comment.
Thanks @trungleduc, this is great!
I left a small comment to discuss how we would like to architecture the different packages in the long run, if in case this needs a bit more thinking.
Also it looks like it will be easier to test this new feature if the PR is merged and available in a release (which could be a pre-release). So the best for now would probably be to move forward with this, make a new release, and iterate on fixes and adjustments if needed in follow-up PRs.
|
Also @yuvipanda if you would like to start testing this on some deployments and have some feedback or issues, please don't hesitate to reach out! |
User facing changes
This PR allows
tljh-repo2dockerto usebinderhubservice as the image build backend. By default, it still uses the local docker engine to build image viarepo2docker, but if thebinderhub_urlis specified, it will switch to usingbinderhubservice instead.New configurations
binderhub_url: The optional URL of thebinderhubservice. If available,tljh-repo2dockerwill use this service to build images.db_url: The database's connection string.tljh-repo2dockerneeds a database to store the image metadata. By default, it will create asqlitedatabase in the starting directory of the service. To use other databases (PostgreSQLorMySQL), users need to specify the connection string via this config and install the additional drivers (asyncpgoraiomysql).New environment dialog when using
binderhubserviceNote
The
binderhubbuild backend does not support adding custom build arguments and private repository credentials from the interface.Code changes
binderhubservice.binderhubbuild backend.