update python wrapper for boost 1.65 #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you upload all the changes to quickly clone them |
|
This is my fork where I have the changes applied: https://github.com/zweistein/ecto_opencv/tree/migration_To_Ubunt18.04 |
|
good job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #45 Melodic ROS, Ubuntu 18.04 with Boost 1.65 migration
From Boost 1.63 arrays are included to
numpywhich is in the python wrapper. Thus namespace change was required.Backward compatibility was not checked and should not work, thus a new tag and readme note should be created. The rest of
ecto,ecto_pcl,ecto_ros, andecto_image_pipeline