-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new boards namino rosso / arancio #1193
Conversation
Hi @a-sapuppo, thanks for the PR. In this commit you disabled PSRAM by default. Shouldn't it be reflected in this PR as well? Also, do these boards require 1200bps touch? You didn't specify it in the manifests. |
no good ? |
PSRAM should be enabled or disabled by default? |
disabled by default |
Do these boards require 1200bps touch when uploading? |
use_1200bps_touch added |
OK, there are some other fixes required, it will be easier for me to add it by myself than ask you each time, but you need allow maintainers to edit the PR, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork |
write granted |
Thanks, merged! |
Namino Boards: Namino combines the industrial world with the world of makers by making digital analog inputs, outputs and compatible Arduino shields available on the same board.
CPU: ESP32-S3-WROOM-1U-N4R8