-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for important commands #210
Conversation
6eb7a55
to
ac8ad3e
Compare
171b255
to
86c975e
Compare
5a59989
to
a961dba
Compare
a961dba
to
276fb05
Compare
72bd9b1
to
fe736f0
Compare
364339d
to
53779b4
Compare
dc34f0b
to
4b952de
Compare
Test the mount:list command
4a7b086
to
9ab9d6d
Compare
9ab9d6d
to
1f4be19
Compare
1f4be19
to
b69f226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice one, this will help us on so many fronts 🎉
I have just a couple of questions, the rest of the code is generally looking great, I put most of my focus on the "testing infra" code.
Pick the GoReleaser build for integration tests by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested on the GitLab side
Rationale:
Awkwardnesses were:
cmd.Dir = os.TempDir()
when running a command: so that the legacy CLI doesn't do unpredictable things with the "current project".chi
router package as a dependency for the test mocks. That probably does not affect the production build (on this branch, it's about 1KB smaller for me).Follow up steps could be: