-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PHP to 8.2 and enable zlib #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove deprecation warning before bumping the PHP version.
I get the following ones when logging in:
Deprecated: http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in /home/akalipetis/.platformsh/oauth-listener/index.php on line 45
Warning: Cannot modify header information - headers already sent by (output started at /home/akalipetis/.platformsh/oauth-listener/index.php:45) in /home/akalipetis/.platformsh/oauth-listener/index.php on line 187
Warning: Cannot modify header information - headers already sent by (output started at /home/akalipetis/.platformsh/oauth-listener/index.php:45) in /home/akalipetis/.platformsh/oauth-listener/index.php on line 187
Warning: Cannot modify header information - headers already sent by (output started at /home/akalipetis/.platformsh/oauth-listener/index.php:45) in /home/akalipetis/.platformsh/oauth-listener/index.php on line 187
Weird, I don't get that when I run |
Things that stop it working, yes. There are definitely deprecations, which are unavoidable as it still supports PHP 5.6+ and various libraries include deprecated code (mostly Guzzle). They're usually hidden unless you define |
Rebased |
Rebased again / updated to 8.2.10 And I've updated the OP comment with a list of extensions that we'd want to check exist in the PHP build |
@akalipetis could we build PHP |
Rebased + updated to 8.2.11 |
I've added zlib I haven't tested if this builds OK for Windows / OS X / ARM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐻
Deprecation warnings are gone and everything seems to be working great! |
#54
Check various needed extensions are installed ... I've checked for linux/amd64:
plus desirable extensions:
tunnel:open
command)