-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Average Scroll Depth Metric: imported data #4915
Open
RobertJoonas
wants to merge
13
commits into
master
Choose a base branch
from
scroll-depth-full-csv
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+657
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertJoonas
force-pushed
the
scroll-depth-full-csv
branch
from
December 18, 2024 18:36
a083472
to
03327af
Compare
RobertJoonas
changed the title
[WIP] Scroll depth full csv
[WIP] Average Scroll Depth Metric: imported data
Dec 18, 2024
RobertJoonas
force-pushed
the
scroll-depth-full-csv
branch
from
December 19, 2024 12:55
dbde2ce
to
8543cee
Compare
RobertJoonas
changed the title
[WIP] Average Scroll Depth Metric: imported data
Average Scroll Depth Metric: imported data
Dec 19, 2024
|
RobertJoonas
force-pushed
the
scroll-depth-full-csv
branch
from
December 19, 2024 13:07
8543cee
to
9470502
Compare
RobertJoonas
force-pushed
the
scroll-depth-full-csv
branch
from
December 19, 2024 13:08
9470502
to
1d7beb7
Compare
ruslandoga
approved these changes
Dec 24, 2024
Co-authored-by: ruslandoga <doga.ruslan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR starts making use of two new columns in the
imported_pages
table. The relevant migrations are already merged and executed:pageleave_visitors
field)The objectives of this PR are to:
scroll_depth
metric in the full CSV export/import featurescroll_depth
from imported data (if it exists) in stats queriesReturning warnings about imported data not being included in scroll_depth calculation will be implemented in a follow up PR.
Tests
Changelog
Documentation
Dark mode