Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average Scroll Depth Metric: imported data #4915

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

RobertJoonas
Copy link
Contributor

@RobertJoonas RobertJoonas commented Dec 17, 2024

Changes

This PR starts making use of two new columns in the imported_pages table. The relevant migrations are already merged and executed:

  1. Redo migration: Add scroll_depth to imported_pages #4926
  2. Average Scroll Depth Metric: another imported schema migration #4932 (pageleave_visitors field)

The objectives of this PR are to:

  • Include the scroll_depth metric in the full CSV export/import feature
  • Include scroll_depth from imported data (if it exists) in stats queries

Returning warnings about imported data not being included in scroll_depth calculation will be implemented in a follow up PR.

Tests

  • Automated tests have been added

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@RobertJoonas RobertJoonas changed the title Scroll depth full csv [WIP] Scroll depth full csv Dec 17, 2024
@RobertJoonas RobertJoonas marked this pull request as draft December 17, 2024 13:23
@RobertJoonas RobertJoonas changed the title [WIP] Scroll depth full csv [WIP] Average Scroll Depth Metric: imported data Dec 18, 2024
@RobertJoonas RobertJoonas marked this pull request as ready for review December 19, 2024 11:59
@RobertJoonas RobertJoonas changed the title [WIP] Average Scroll Depth Metric: imported data Average Scroll Depth Metric: imported data Dec 19, 2024
Copy link

Preview environment👷🏼‍♀️🏗️
PR-4915

lib/plausible/exports.ex Outdated Show resolved Hide resolved
lib/workers/export_analytics.ex Show resolved Hide resolved
test/plausible/imported/csv_importer_test.exs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants