Skip to content

Commit

Permalink
Merge pull request #77 from pleonex/feature/release-dep
Browse files Browse the repository at this point in the history
🐛 Missing dependency to restore GitReleaseManager when uploading binaries
  • Loading branch information
pleonex authored Nov 23, 2023
2 parents d24f3f8 + 06e14d7 commit 1a46c6f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions docs/articles/getting-started/setup-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ following [project template](https://github.com/pleonex/template-csharp).
4. Review `build.yml` to remove / add OS platforms to run build and tests.
5. Enable GitHub Pages in the repository settings
1. Select GitHub Actions as the source.
2. From _Environments_, select `github-pages`. Under _Deployment branches and
tags_ add a new rule to allow publishing docs from the tags `v*`.

## Collaboration files

Expand Down
2 changes: 1 addition & 1 deletion docs/articles/recipe/github.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ the current version (if any) into `ChangelogNextFile`.
- Task name: `PleOps.Recipe.GitHub.UploadReleaseBinaries`
- Type:
[`UploadReleaseBinaries`](xref:Cake.Frosting.PleOps.Recipe.GitHub.UploadReleaseBinariesTask)
- Depends on: none
- Depends on: [`RestoreTools`](./common.md#restore-tools)
- Condition: build type is `Stable` and `GitHubToken` is not empty.
- Build context: `PleOpsBuildContext`
- Uses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ namespace Cake.Frosting.PleOps.Recipe.GitHub;
/// This action only runs for stable builds if the GitHub token is present.
/// </remarks>
[TaskName("PleOps.Recipe.GitHub.UploadReleaseBinaries")]
[IsDependentOn(typeof(Common.RestoreToolsTask))]
public class UploadReleaseBinariesTask : FrostingTask<PleOpsBuildContext>
{
/// <inheritdoc />
Expand Down

0 comments on commit 1a46c6f

Please sign in to comment.