Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VT-6446: Fix for "Unable to build TypeScript on Version" #316

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Change Log

## [v4.56.2](https://github.com/plivo/plivo-node/tree/v4.56.2) (2023-09-01)
**Bug fix - Unable to build TypeScript on Version 4.56.0**
- Fix TypeScript build error

## [v4.56.1](https://github.com/plivo/plivo-node/tree/v4.56.1) (2023-09-01)
**Bug Fix - unrent powerpack number**
- Fix for Error: invalid powerpack number delete request (400) - Unrent Powerpack Number

## [v4.56.0](https://github.com/plivo/plivo-node/tree/v4.56.0) (2023-08-25)
**Feature - Added New Param 'carrier_fees', 'carrier_fees_rate', 'destination_network' in Get Message and List Message APIs**
- Added new params on message get and list response
Expand Down
8 changes: 3 additions & 5 deletions lib/resources/powerpacks.js
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ export class Powerpack extends PlivoResource {

remove_number(number, unrent = false) {
var params = {};
params['unrent'] = unrent.toString();
params['unrent'] = unrent;
let path = 'NumberPool/' + this.number_pool_id + '/Number/' + number + '/';
let client = this[clientKey];
return new Promise((resolve, reject) => {
Expand All @@ -328,7 +328,7 @@ export class Powerpack extends PlivoResource {
}
remove_tollfree(tollfree, unrent = false) {
var params = {};
params['unrent'] = unrent.toString();
params['unrent'] = unrent;
let path = 'NumberPool/' + this.number_pool_id + '/Tollfree/' + tollfree + '/';
let client = this[clientKey];
return new Promise((resolve, reject) => {
Expand Down Expand Up @@ -483,9 +483,7 @@ export class Powerpack extends PlivoResource {
*/
delete(unrent_numbers = false) {
let params = {};
if (typeof unrent_numbers === 'boolean') {
params.unrent_numbers = unrent_numbers.toString();
}
params.unrent_numbers = unrent_numbers;
let path = 'Powerpack/' + this.uuid + '/';
return super.customexecuteAction(path.toString().trim(), 'DELETE', params);
}
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "plivo",
"version": "4.56.0",
"version": "4.56.2",
"description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
"homepage": "https://github.com/plivo/plivo-node",
"files": [
Expand Down
8 changes: 6 additions & 2 deletions types/resources/maskingSession.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export class MaskingSessionInterface extends PlivoResourceInterface {
* @returns {Promise<PlivoGenericResponse>} - Resolves to a PlivoGenericResponse object
* @throws {Error} - Throws an error if the list masking sessions request fails
*/
listMaskingSession(params ? : {}): Promise < ListMaskingSessionResponse > ;
listMaskingSession(params ? : {}): Promise < ListMaskingSessionResponse > ;

/**
* Get a masking session
Expand All @@ -159,4 +159,8 @@ export class MaskingSessionInterface extends PlivoResourceInterface {
* @fail {Error} returns Error
*/
deleteMaskingSession(sessionUuid: string): Promise < DeleteMaskingSessionResponse > ;
}
}
import {
PlivoResource,
PlivoResourceInterface
} from "../base";
Loading