Skip to content

Commit

Permalink
Merge pull request #145 from plivo/VT-2496
Browse files Browse the repository at this point in the history
Handles GET method for start recording
  • Loading branch information
nixonsam authored Sep 14, 2020
2 parents 79999df + a0f719b commit ad1af27
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Change Log

## [4.10.2](https://github.com/plivo/plivo-python/tree/v4.10.2) (2020-09-14)
- Fix GET callback_method for Start Recording API.

## [4.10.1](https://github.com/plivo/plivo-python/tree/v4.10.1) (2020-09-11)
- Fix Play in calls for asynchronous requests.

Expand Down
8 changes: 4 additions & 4 deletions plivo/resources/calls.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def record(self,
transcription_url=None,
transcription_method=None,
callback_url=None,
callback_mathod=None):
callback_method=None):
return self.client.calls.record(self.id,
**to_param_dict(self.record, locals()))

Expand All @@ -43,7 +43,7 @@ def start_recording(self,
transcription_url=None,
transcription_method=None,
callback_url=None,
callback_mathod=None):
callback_method=None):
return self.client.calls.start_recording(self.id,
**to_param_dict(
self.start_recording,
Expand Down Expand Up @@ -264,7 +264,7 @@ def record(self,
transcription_url=None,
transcription_method=None,
callback_url=None,
callback_mathod=None):
callback_method=None):
return self.start_recording(**to_param_dict(self.start_recording,
locals()))

Expand All @@ -277,7 +277,7 @@ def start_recording(self,
transcription_url=None,
transcription_method=None,
callback_url=None,
callback_mathod=None):
callback_method=None):
return self.client.request('POST', ('Call', call_uuid, 'Record'),
to_param_dict(self.start_recording,
locals()), is_voice_request=True)
Expand Down
2 changes: 1 addition & 1 deletion plivo/version.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# -*- coding: utf-8 -*-
__version__ = '4.10.1'
__version__ = '4.10.2'
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

setup(
name='plivo',
version='4.10.1',
version='4.10.2',
description='A Python SDK to make voice calls & send SMS using Plivo and to generate Plivo XML',
long_description=long_description,
url='https://github.com/plivo/plivo-python',
Expand Down

0 comments on commit ad1af27

Please sign in to comment.