Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Pillow to 10.2.0. #906

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Upgrade Pillow to 10.2.0. #906

merged 1 commit into from
Jan 29, 2024

Conversation

mauritsvanrees
Copy link
Member

This should work, now that plone/plone.scale#90 is merged.

I am inclined to say we only do this for Plone 6.1, not 6.0. The release has backwards incompatibilities. Should not be noticeable under normal use, but you never know what projects have as extra code. I am not aware of anything new in Pillow 10 that we would really want to actively use in Plone. So 9.5 should still be fine for Plone 6.0.

This should work, now that plone/plone.scale#90 is merged.

I am inclined to say we only do this for Plone 6.1, not 6.0.  The release has backwards incompatibilities.  Should not be noticeable under normal use, but you never know what projects have as extra code.
I am not aware of anything new in Pillow 10 that we would really want to actively use in Plone.  So 9.5 should still be fine for Plone 6.0.
@mauritsvanrees
Copy link
Member Author

@jenkins-plone-org please run jobs

@mauritsvanrees mauritsvanrees merged commit 7b83a32 into 6.1 Jan 29, 2024
20 checks passed
@mauritsvanrees mauritsvanrees deleted the maurits-pillow-1020 branch January 29, 2024 16:50
@wesleybl
Copy link
Member

wesleybl commented May 9, 2024

@mauritsvanrees would it be possible to use Pillow version 10 in Plone 6.0? In theory, version 9.5.0 does not support Python 3.12:

https://github.com/python-pillow/Pillow/blob/9.5.0/setup.cfg#L19

And we don't have wheels for Python 3.12 for version 9.5.0:

https://pypi.org/project/pillow/9.5.0/#files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants