Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Mockup documentation #1345

Merged
merged 13 commits into from
Feb 28, 2024
Merged

Improve the Mockup documentation #1345

merged 13 commits into from
Feb 28, 2024

Conversation

thet
Copy link
Member

@thet thet commented Oct 7, 2023

This is a preparation to include the Mockup documentation in the Plone documentation.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I made some minor grammar and MyST syntax changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/pat/textareamimetypeselector/README.md Outdated Show resolved Hide resolved
src/pat/textareamimetypeselector/README.md Outdated Show resolved Hide resolved
src/pat/texteditor/README.md Outdated Show resolved Hide resolved
src/pat/tinymce/README.md Outdated Show resolved Hide resolved
src/pat/tree/README.md Outdated Show resolved Hide resolved
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@petschki
Copy link
Member

I'd say lets publish this state to the documentation. We can fix the gaps afterwards.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two unresolved questions. Once those are answered and fixed, then I approve and we can merge this. Please let me know. Thank you! @petschki @thet

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@stevepiercy stevepiercy marked this pull request as ready for review November 1, 2023 08:09
@petschki petschki force-pushed the improve-docs branch 2 times, most recently from e638a12 to e409355 Compare November 2, 2023 08:54
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Contributor

I will merge if it goes green. Thank you!

@stevepiercy stevepiercy merged commit 18d84e9 into master Feb 28, 2024
3 checks passed
@stevepiercy stevepiercy deleted the improve-docs branch February 28, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants