Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE 6 #1346

Merged
merged 7 commits into from
Oct 20, 2023
Merged

TinyMCE 6 #1346

merged 7 commits into from
Oct 20, 2023

Conversation

petschki
Copy link
Member

@petschki petschki commented Oct 19, 2023

Note: There are renamed menu and toolbar items for the format menu. You have to rename them manually right now.

We map the old names now here until the configuration values changed.

@thet
Copy link
Member

thet commented Oct 19, 2023

@petschki can we add aliases for these old values (formats and styleselect) in Mockup itself? that might be easier than adding an upgrade step and it would be better backwards compatible - you could use Mockup with older versions of Plone too, maybe.

Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need aliases for the old tinymce toolbar/menu values. Plus, after merging we also need to update the default options for the tinymce control panel to reflect those new values.

Other than that: 🎉 💯

thet
thet previously approved these changes Oct 20, 2023
@thet thet dismissed their stale review October 20, 2023 05:54

There are test failures...

@petschki
Copy link
Member Author

just fixed the tests.

I think semantic versioning would require a 5.2.0 release of this ... should we got with an alpha first? and plone.staticresources = 2.2.0 too ...

@thet
Copy link
Member

thet commented Oct 20, 2023

Yes for 5.2.0.
An alpha version might be good to check if the integration works properly with Plone.

@petschki petschki merged commit d7686b9 into master Oct 20, 2023
2 checks passed
@petschki petschki deleted the petschki-tinymce6 branch October 20, 2023 07:24
@MrTango
Copy link
Contributor

MrTango commented Oct 24, 2023

great job! thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants