Cause kaleido to explicitly fail if no chromium: #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we were letting choreographer handle it.
|
Hey Greg, this error will be more clean for users that they need to have chrome installed! |
|
Not sure if it solves #223 but it may |
| @@ -59,6 +59,8 @@ def __init__(self, plotlyjs=None, mathjax=None, topojson=None, mapbox_access_tok | |||
| 'kaleido_scopes.js' | |||
| ) | |||
| path = os.environ.get("BROWSER_PATH", which_browser()) | |||
| if not path: | |||
| raise RuntimeError("Kaleido now requires that chrome/chromium is installed separately. Kaleido will try to detect it automatically, but the environmental error \"BROWSER_PATH\" can also be set") | |||
There was a problem hiding this comment.
Suggested change
| raise RuntimeError("Kaleido now requires that chrome/chromium is installed separately. Kaleido will try to detect it automatically, but the environmental error \"BROWSER_PATH\" can also be set") | |
| raise RuntimeError("Kaleido now requires that chrome/chromium is installed separately. Kaleido will try to detect it automatically, but the environment variable \"BROWSER_PATH\" can also be set") |
There was a problem hiding this comment.
wow okay this is correct why did I miss this? thank you
gvwilson
approved these changes
Nov 18, 2024
Closed
|
Not sure how to circumvent this new requirement in a serverless compute on Azure Databricks... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were letting choreographer handle it.