-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* - refactor: isolate dash component layer from component implementation - duplicate component contract in TS * update for build js/py * - fix python component packaging regression - bump version to rc6 * Fix visual tests regression * (wip) refactor controlled table * @types * refactor table clipboard usage * clean up * rename * pr review fixes * fix bug in test script * fix test * update test script * fix tests * fix tests * tests -- remove async/await syntax * fix tests * - remove row component - 3 tables for fixed rows/columns and content - update TS props * remove test code * fix test * remove test / broken by Cypress.io * cypress version * fix cell selection test * fix percy tests * prevent useless cell updates once again * styling, copy/paste, navigation regressions * build, variables renamed * fix next/previous regression * fix test regressions * table styling regression * - fixed rows/columns regression testing + fixes - percy tests for fixed rows/columns * fix test? * fix test? * revert percy removal * multi and single column sorting support * basic sorting e2e test * linting * - add runtime logger configuration override - fix scrolling issue in prod environment * - fix merged cells / hidden cells w/ fixed col & rows - additional visual tests for merged, fixed, hidden combo * remove .only * - fix delete / select when sorted/filtered - additional tests for delete/select when sorted/filtered * fix copy/paste regression * bumping version to rc7 * fix percy tests
- Loading branch information
1 parent
0e8321f
commit c45fb00
Showing
28 changed files
with
413 additions
and
160 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,6 @@ | ||
# Changelog | ||
|
||
## RC6 - Sorting props | ||
|
||
- Additional sorting_type prop that can take value 'multi' or 'single' | ||
This prop defines whether the user can sort based on multiple columns or can only sort by one column at a time. The default value is 'single'. |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import * as R from 'ramda'; | ||
|
||
import Logger from 'core/Logger'; | ||
import { SortSettings, ISortSetting, SortDirection } from 'core/sorting'; | ||
|
||
export default ( | ||
settings: SortSettings, | ||
setting: ISortSetting | ||
): SortSettings => { | ||
Logger.trace('multi - updateSettings', settings, setting); | ||
|
||
settings = R.clone(settings); | ||
|
||
if (setting.direction === SortDirection.None) { | ||
const currentIndex = R.findIndex(s => s.columnId === setting.columnId, settings); | ||
|
||
if (currentIndex !== -1) { | ||
settings.splice(currentIndex, 1); | ||
} | ||
} else { | ||
const currentSetting = R.find(s => s.columnId === setting.columnId, settings); | ||
|
||
if (currentSetting) { | ||
currentSetting.direction = setting.direction; | ||
} else { | ||
settings.push(setting); | ||
} | ||
} | ||
|
||
return settings; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import Logger from 'core/Logger'; | ||
import { SortSettings, ISortSetting, SortDirection } from 'core/sorting'; | ||
|
||
export default ( | ||
settings: SortSettings, | ||
setting: ISortSetting | ||
): SortSettings => { | ||
Logger.trace('single - updateSettings', settings, setting); | ||
|
||
return setting.direction === SortDirection.None ? | ||
[] : | ||
[setting]; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.