Isolate names(...) in event_data() to prevent spurious updates (#…

…2339) * Isolate names(session$userData$plotlyInputStore) to prevent spurious updates (#2337) * Update NEWS.md
plotly · Apr 27, 2024 · dc6455f · dc6455f
1 parent 16261c3
commit dc6455f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # plotly (development version)
 
+## Bug fixes
+
+* Closed #2337: Creating a new `event_data()` handler no longer causes a spurious reactive update of existing `event_data()`s. (#2339)
+
 # 4.10.4
 
 ## Improvements

diff --git a/R/shiny.R b/R/shiny.R
@@ -193,7 +193,7 @@ event_data <- function(
 
   } else {
 
-    eventHasStorage <- eventID %in% names(session$userData$plotlyInputStore)
+    eventHasStorage <- eventID %in% shiny::isolate(names(session$userData$plotlyInputStore))
 
     if (!eventHasStorage) {
       # store input value as a reactive value to leverage caching