-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserving 64 bit floats for WebGL 2D plotting #1033
Conversation
d6fde5e
to
a276f6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution. Looking forward to this once #995 is complete 👍
var float32ArrayOut = new Float32Array(len); | ||
for(var i = 0; i < len; i++) float32ArrayOut[i] = float32ArrayIn[i]; | ||
return float32ArrayOut; | ||
module.exports = function truncate(arrayIn, len) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done here.
Let's change the file name though to typed_array_truncate.js
(or something better?))
a7b2249
to
066f45d
Compare
@monfera amazing work 🎉 I've been playing with Go ahead and merge + publish all the gl-vis PRs. Once that's done, you'll need to rebase off Then, we should modify the existing Thanks again for your efforts 👍 |
d34aa72
to
70ff88e
Compare
@etpinard all the above steps are now done except the update to |
yes please! |
334fc19
to
68cec41
Compare
68cec41
to
d528fa7
Compare
Solution for #995
Rebased on #413 to allow testing with a date axis.
For non-fancy
scattergl
, this is also needed: gl-vis/gl-scatter2d#1For fancy
scattergl
, this is also needed: