Multiline gl2d texts #1089
Merged
Multiline gl2d texts #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Oct 26, 2016
| // TODO add support for '\n' in gl-plot2d, | ||
| // For now, replace '\n' with ' ' | ||
| nextTicks[j][i].text = convertHTMLToUnicode(nextTicks[j][i].text + '').replace(/\n/g, ' '); | ||
| nextTicks[j][i].text = convertHTMLToUnicode(nextTicks[j][i].text + ''); |
There was a problem hiding this comment.
It was there and I left it intact, thinking it was in place to coerce it into a string
There was a problem hiding this comment.
I believe nextTicks[j][i].text will always be a string. Let's 🔪 that + ''.
There was a problem hiding this comment.
@etpinard npm run test-image-gl2d returned with errors when I did the 🔪
There was a problem hiding this comment.
Ha. Good to know. Revert the 🔪 and add a comment about the + ''.
monfera
force-pushed
the
multiline
branch
3 times, most recently
from
ef66311 to
b4a21d3
Compare
|
Awesome work @monfera Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR depends on the merge and npm publish of its gl-vis dependency
Purports to fix #1079