Fix color clustering #2377
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -781,9 +781,9 @@ function plot(container, subplot, cdata) { | |
| } | ||
| // fill requires linked traces, so we generate it's positions here | ||
| if(scene.fill2d) { | ||
| var fillOptions = scene.fillOptions.map(function(fillOptions, i) { | ||
|
There was a problem hiding this comment. Can you add a jasmine test to 🔒 this down? |
||
| var cdscatter = cdata[i]; | ||
| if(!fillOptions || !cdscatter || !cdscatter[0] || !cdscatter[0].trace) return {positions: []}; | ||
| var cd = cdscatter[0]; | ||
| var trace = cd.trace; | ||
| var stash = cd.t; | ||
|
|
@@ -863,9 +863,11 @@ function plot(container, subplot, cdata) { | |
|
|
||
| fillOptions.opacity = trace.opacity; | ||
| fillOptions.positions = pos; | ||
|
|
||
| return fillOptions; | ||
|
There was a problem hiding this comment. Can you briefly explain why this fixes #2376 ? There was a problem hiding this comment. That fixes #2354. That is internal |
||
| }); | ||
|
|
||
| scene.fill2d.update(fillOptions); | ||
|
There was a problem hiding this comment. You forgot to There was a problem hiding this comment. This is the one that accidentally made it into master, as mentioned above
But since I had that in master as the base of my own PR, I removed it there #2379 (comment) |
||
| } | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update the package-lock file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!