-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover / unhover events on the 2d WebGL plots #994
Merged
+571
−13
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
53c7c11
test
monfera c4baeb2
hover, unhover
monfera 359d50a
adds click emission; adds test cases; uses hasWebGLSupport
monfera 1e56d7f
PR feedback: enriching event callback data
monfera 2e8db74
PR feedback: enriching event callback data - indices
monfera 9f77c11
DRY up event emission
monfera 2e54a99
PR feedback - cover the other gl2d plot types
monfera 57cec8c
PR feedback - cover the other gl2d plot types - other plot type tests
monfera a9b8b3e
PR feedback - cover the other gl2d plot types - contourgl plot type test
monfera c1abd3e
PR feedback - return [x, y] only
monfera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
var mouseEvent = require('./mouse_event'); | ||
|
||
module.exports = function hover(x, y) { | ||
mouseEvent('mousemove', x, y); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
var mouseEvent = require('./mouse_event'); | ||
|
||
module.exports = function click(x, y) { | ||
mouseEvent('mousemove', x, y, {buttons: 0}); | ||
|
||
window.setTimeout(function() { | ||
|
||
mouseEvent('mousedown', x, y, {buttons: 1}); | ||
|
||
window.setTimeout(function() { | ||
|
||
mouseEvent('mouseup', x, y, {buttons: 0}); | ||
|
||
}, 50); | ||
|
||
}, 150); | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etpinard I added
this.fullData
andthis._inputs
to retain info prerequisite for the event data contents you suggested (below), please let me know if there's a better way. Working oncurveNumber
andpointNumber
now, I suppose these are just the indices.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice.