Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maplibre traces & subplots to templates similar to mapbox traces #4880

Closed
wants to merge 3 commits into from
Closed

Add maplibre traces & subplots to templates similar to mapbox traces #4880

wants to merge 3 commits into from

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Nov 14, 2024

Fixes #4879.

@archmoj
Copy link
Contributor Author

archmoj commented Nov 14, 2024

I manually updated these files.
@marthacryan Is packages/python/plotly/templategen is unused?

@gvwilson
Copy link
Contributor

gvwilson commented Nov 15, 2024 •
edited
Loading

@archmoj when you say "manually updated" were the JSON files edited by hand or generated with the modified templategen? i.e., is this one replaced by #4881 ?

@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken labels Nov 15, 2024
@gvwilson gvwilson mentioned this pull request Nov 15, 2024
Merged
@gvwilson
Copy link
Contributor

using #4881 instead

@gvwilson gvwilson closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson

@marthacryan marthacryan Awaiting requested review from marthacryan

Assignees

@archmoj archmoj

Labels
fix fixes something broken P1 needed for current cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add scattermap and map to plotly.py templates similar to scattermapbox and mapbox
2 participants
@archmoj @gvwilson