Better symbol visibility settings

plugdata-team · Sep 4, 2023 · 5a47162 · 5a47162
1 parent b8b1e19
commit 5a47162
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -397,16 +397,6 @@ set_target_properties(plugdata_standalone PROPERTIES BUNDLE_OUTPUT_DIRECTORY_REL
 set_target_properties(plugdata_standalone PROPERTIES RUNTIME_OUTPUT_DIRECTORY_RELEASE ${PLUGDATA_PLUGINS_LOCATION}/Standalone)
 set_target_properties(plugdata_standalone PROPERTIES LIBRARY_OUTPUT_DIRECTORY_RELEASE ${PLUGDATA_PLUGINS_LOCATION}/Standalone)
 
-# To make sure externals work, we need to make the standalone have its symbols be visible
-target_compile_options(plugdata_standalone PRIVATE -fvisibility=default)
-
-set_target_properties(plugdata PROPERTIES CXX_VISIBILITY_PRESET hidden)
-set_target_properties(plugdata_fx PROPERTIES CXX_VISIBILITY_PRESET hidden)
-if(APPLE)
-set_target_properties(plugdata_midi PROPERTIES CXX_VISIBILITY_PRESET hidden)
-endif()
-
-
 set_target_properties(plugdata PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${PLUGDATA_PLUGINS_LOCATION})
 set_target_properties(plugdata PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${PLUGDATA_PLUGINS_LOCATION})
 

diff --git a/Libraries/CMakeLists.txt b/Libraries/CMakeLists.txt
@@ -394,6 +394,8 @@ if(MSVC)
 else()
     add_library(pd STATIC ${SOURCE_FILES})
     target_compile_definitions(pd PRIVATE ${LIBPD_COMPILE_DEFINITIONS})
+
+    # To make sure externals work, we need to make single-instance pd have its symbols be visible
     target_compile_options(pd PRIVATE -fvisibility=default)
 endif()