update zaproxy action with customizable secret

pluribus-one · Nov 27, 2024 · 6d8dee1 · 6d8dee1
1 parent 769282d
commit 6d8dee1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/zaproxy.yml b/.github/workflows/zaproxy.yml
@@ -10,12 +10,11 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        cluster_ip: [18.185.179.187]
-        port: [31546,31547]
+        port: [31547]
 
     steps:
       - name: ZAP Scan
         uses: zaproxy/action-full-scan@v0.11.0
         with:
-          target: http://${{ matrix.cluster_ip }}:${{ matrix.port}}
-          artifact_name: zap_scan_${{ matrix.cluster_ip }}_${{ matrix.port }}
+          target: http://${{ secrets.CLUSTER_IP }}:${{ matrix.port}}
+          artifact_name: zap_scan_${{ secrets.CLUSTER_IP }}_${{ matrix.port }}
diff --git a/kube/apps/frontend-service.yaml b/kube/apps/frontend-service.yaml
@@ -14,6 +14,7 @@ spec:
   ports:
     # the port that this service should serve on
   - port: 80
+    nodePort: 31547
   selector:
     app: guestbook
     tier: frontend