More CodeQL Fixes

pmachapman · Jan 18, 2023 · 0ffb906 · 0ffb906
1 parent abb725c
commit 0ffb906
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/GoToBible.Engine/GotoBibleApiRenderer.cs b/GoToBible.Engine/GotoBibleApiRenderer.cs
@@ -17,7 +17,7 @@ namespace GoToBible.Engine;
 /// The GoTo.Bible API Renderer.
 /// </summary>
 /// <seealso cref="GoToBible.Model.IRenderer" />
-public class GotoBibleApiRenderer : IRenderer
+public sealed class GotoBibleApiRenderer : IRenderer
 {
     /// <summary>
     /// The HTTP client.
@@ -72,7 +72,7 @@ public async Task<RenderedPassage> RenderAsync(RenderingParameters parameters, b
     /// Releases unmanaged and - optionally - managed resources.
     /// </summary>
     /// <param name="disposing"><c>true</c> to release both managed and unmanaged resources; <c>false</c> to release only unmanaged resources.</param>
-    protected virtual void Dispose(bool disposing)
+    private void Dispose(bool disposing)
     {
         if (!this.disposedValue)
         {

diff --git a/GoToBible.Web/Server/Controllers/TranslationsController.cs b/GoToBible.Web/Server/Controllers/TranslationsController.cs
@@ -86,9 +86,9 @@ public async IAsyncEnumerable<Translation> Get()
             await foreach (Translation translation in provider.GetTranslationsAsync())
             {
                 // Clean up any names we are displaying
-                if (NameSubstitutions.ContainsKey(translation.Name))
+                if (NameSubstitutions.TryGetValue(translation.Name, out string? translationName))
                 {
-                    translation.Name = NameSubstitutions[translation.Name];
+                    translation.Name = translationName;
                 }
 
                 // Make sure this isn't a blocked translation